[SDTEST-786] support logical names for test sessions #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 98.95% 98.95% -0.01%
==========================================
Files 273 273
Lines 13285 13368 +83
Branches 597 600 +3
==========================================
+ Hits 13146 13228 +82
- Misses 139 140 +1 ☔ View full report in Codecov by Sentry. |
…og::CI::TestSession
juan-fernandez
approved these changes
Sep 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for the logical test session names for test visibility.
Now users are able to name their test sessions using
DD_TEST_SESSION_NAMEvariable. If the environment variable is not provided,"#{ci_job_name}-#{test_command}"is used as default.Motivation
Currently test sessions suffer from unstable fingerprints issue: we use the full test command as the test session identifier right now, and test command might have some random bits (like seed for example). This makes every test session to be considered new by the Datadog's backend, and breaks some features - for example, ITR savings calculation.
This is the first step to migrate to the new definition of test session name.
How to test the change?
Unit tests are provided
Tested using sidekiq project on production:
